This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Delete new row when cancel is clicked #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1766
💛 - Coveralls |
atiratree
suggested changes
May 6, 2019
| onStepDataChanged = (tabKey, value, valid, editing = false) => { | ||
| const validatedTabData = validateTabData(tabKey, value, valid); | ||
| this.safeSetState(state => ({ | ||
| editing, |
Contributor
There was a problem hiding this comment.
I think the tab should merely request to lock the createVmWizard and not take Wizard state into account. This is very useful when using asynchronous actions.
I suggest something like:
{
stepData: {
[tabKey]: {
lockStep
}
}
}
Contributor
Author
There was a problem hiding this comment.
done, lockStep is under [tabKey] now
|
|
||
| let type = ON_CANCEL; | ||
| if (this.props.rows[index].newRow) { | ||
| rows = this.props.rows.filter(row => row.id !== id); |
Contributor
There was a problem hiding this comment.
can't we rather call onDelete method from here?
Contributor
Author
There was a problem hiding this comment.
extracted onDelete to separate function which is now reused where needed
Disable back/next buttons while editing table https://bugzilla.redhat.com/show_bug.cgi?id=1646953
atiratree
approved these changes
May 7, 2019
rawagner
added a commit
to rawagner/web-ui-components
that referenced
this pull request
May 9, 2019
Disable back/next buttons while editing table https://bugzilla.redhat.com/show_bug.cgi?id=1646953
atiratree
pushed a commit
that referenced
this pull request
May 9, 2019
Disable back/next buttons while editing table https://bugzilla.redhat.com/show_bug.cgi?id=1646953
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1646953