This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Do not allow floats as memory value #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1942
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1673
💛 - Coveralls |
mareklibra
approved these changes
May 24, 2019
Contributor
mareklibra
left a comment
mareklibra
left a comment
There was a problem hiding this comment.
In a follow-up, we will definitely need to support float numbers, especially for the import flow.
But for 2.0 as a quick fix, lgtm.
Contributor
Author
|
created issue for future releases #479 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1710775
we should allow floats and different values than Gi for web-ui future versions