BREAKING CHANGE: Update components #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: remove size of tasting and trenta
* chore: yarn add react-icons * feat: add some icons from react-icons/fa * refactor: change props of original icon BREAKING CHANGE: original icon gets the same props as react-icons * chore: update snapshot * chore: export Icon component * fix: remove 'Base', 'Icon' from IGNORE_DIRS
…res/ttmz # Conflicts: # src/index.test.ts
* chore: change key name of color to constant case BREAKING CHANGE: pascal case doesn't support. * chore: update snapshots
# Conflicts: # src/components/CheckboxLabel/CheckboxLabel.tsx # src/components/Field/Field.tsx # src/components/Input/Input.tsx # src/components/Pagination/PaginationItem.tsx # src/components/RadioLabel/RadioLabel.tsx
Update size of theme
Export theme
Add Dialog component and remove Modal component
Fix dropdown content position bug
Change component name
Change interface of Button, Select and Checkbox to conform to the DOM interface
Change Input interface to conform to the DOM interface
ghost
requested review from
nabeliwo
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All PRs.
https://github.com/kufu/smarthr-ui/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed+base%3Afeatures%2Fttmz