Skip to content

Conversation

timothycoleman
Copy link
Contributor

@timothycoleman timothycoleman commented Mar 21, 2025

The OAuth and Ldap plugin tests make use of docker containers so

  1. They are not run on the windows build, because GHA windows machines cannot run linux containers
  2. They are not run on the container builds, we'd have to set up docker in docker

They are, however, run on the Ubuntu build, which is the same as they were run on previously

Co-authored-by: Yo Eight

@timothycoleman timothycoleman requested a review from a team as a code owner March 21, 2025 10:28
@timothycoleman timothycoleman changed the title stuff from yorick that looks fine to me move plugins experiments Mar 21, 2025
@timothycoleman timothycoleman marked this pull request as draft March 21, 2025 10:29
@timothycoleman timothycoleman force-pushed the timothycoleman/wire-plugins branch from 1bd04d3 to 5b1b2a7 Compare March 21, 2025 10:34
Copy link
Contributor

github-actions bot commented Mar 21, 2025

Qodana for .NET

39 new problems were found

Inspection name Severity Problems
Unused parameter (private accessibility) 🔶 Warning 10
Possible multiple enumeration 🔶 Warning 3
Redundant using directive 🔶 Warning 3
Conditional access qualifier expression is known to be null or not null 🔶 Warning 2
Possible 'System.NullReferenceException' 🔶 Warning 2
Assignment is not used 🔶 Warning 2
Redundant cast 🔶 Warning 2
Auto-property accessor is never used (private accessibility) 🔶 Warning 2
Type member is never used (private accessibility) 🔶 Warning 2
Do not use object initializer for 'using' variable 🔶 Warning 2
Access to a static member of a type via a derived type 🔶 Warning 1
Possible 'null' assignment to non-nullable entity 🔶 Warning 1
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 1
Invalid XML documentation comment 🔶 Warning 1
Non-accessed field (private accessibility) 🔶 Warning 1
Non-accessed positional property (private accessibility) 🔶 Warning 1
Redundant argument with default value 🔶 Warning 1
Redundant member initializer 🔶 Warning 1
String.LastIndexOf is culture-specific (string.LastIndexOf(string) is culture-specific) 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@timothycoleman timothycoleman force-pushed the timothycoleman/wire-plugins branch from 5b1b2a7 to 1322d1b Compare March 21, 2025 10:39
@timothycoleman timothycoleman force-pushed the timothycoleman/move-plugins branch from a42ac1d to 070fdff Compare March 21, 2025 15:37
@timothycoleman timothycoleman changed the base branch from timothycoleman/move-plugins to master March 21, 2025 16:06
@timothycoleman timothycoleman changed the base branch from master to timothycoleman/move-plugins March 24, 2025 15:31
@timothycoleman timothycoleman force-pushed the timothycoleman/wire-plugins branch 2 times, most recently from e150efb to dafaa95 Compare March 24, 2025 15:37
Base automatically changed from timothycoleman/move-plugins to master March 24, 2025 15:44
@timothycoleman timothycoleman force-pushed the timothycoleman/wire-plugins branch 3 times, most recently from eb593af to aeb1f00 Compare March 24, 2025 18:29
The OAuth and Ldap plugin tests make use of docker containers so
1. They are not run on the windows build, because GHA windows machines cannot run linux containers
2. They are not run on the container builds, we'd have to set up docker in docker

They are, however, run on the Ubuntu build.

Co-authored-by: Yo Eight <yo.eight@gmail.com>
@timothycoleman timothycoleman force-pushed the timothycoleman/wire-plugins branch from aeb1f00 to 6aa6b2b Compare March 25, 2025 12:24
@timothycoleman timothycoleman changed the title move plugins experiments Wire CommercialHA and CoupledPlugins plugins into solution and CI Mar 25, 2025
@timothycoleman timothycoleman marked this pull request as ready for review March 25, 2025 12:58
@timothycoleman timothycoleman changed the title Wire CommercialHA and CoupledPlugins plugins into solution and CI [KDB-720] Wire CommercialHA and CoupledPlugins plugins into solution and CI Mar 25, 2025
@timothycoleman timothycoleman merged commit 73d7972 into master Mar 27, 2025
12 checks passed
@timothycoleman timothycoleman deleted the timothycoleman/wire-plugins branch March 27, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants