[KDB-764] Use [] rather than null to represent all events being for one single stream #5052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stream This simplifies the semantics a bit and avoids the risk of a null array being accidentally converted to an empty ReadOnlyMemory<>? when it should have stayed null e.g. this cast is no longer required in the MultiStreamWritesTests: `eventStreamIndexes is null ? (LowAllocReadOnlyMemory<int>?)null : eventStreamIndexes`
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
shaan1337
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the semantics a bit and avoids the risk of a null array being accidentally converted to an empty ReadOnlyMemory<>? when it should have stayed null e.g. this cast is no longer required in the MultiStreamWritesTests:
eventStreamIndexes is null ? (LowAllocReadOnlyMemory<int>?)null : eventStreamIndexes