[KDB-764] Rename storage messages for clarity #5054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. PrepareAck -> UncommittedPrepareChased UncommittedPrepareChased is sent by the StorageChaser when it reads uncommitted prepares 2. CommitAck -> CommitChased CommitChased is sent by the storage chaser when it reads a commit log record or a self commiting prepare that ends an implicit transaction
There was a problem hiding this comment.
Pull Request Overview
This PR renames storage message types in tests to improve clarity on the uncommitted prepare and commit scenarios. Key changes include:
- Replacing StorageMessage.PrepareAck with StorageMessage.UncommittedPrepareChased.
- Replacing StorageMessage.CommitAck with StorageMessage.CommitChased.
- Updating subscriptions and published messages accordingly in various test files.
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/KurrentDB.Core.Tests/Services/RequestManagement/WriteStreamMgr/when_write_stream_gets_timeout_after_cluster_commit.cs | Renamed prepare message to UncommittedPrepareChased and kept commit messages unchanged. |
| src/KurrentDB.Core.Tests/Services/RequestManagement/WriteStreamMgr/when_write_stream_gets_already_committed_and_log_is_committed.cs | Updated prepare message type to UncommittedPrepareChased. |
| src/KurrentDB.Core.Tests/Services/RequestManagement/WriteStreamMgr/when_write_stream_gets_already_committed.cs | Replaced PrepareAck with UncommittedPrepareChased. |
| src/KurrentDB.Core.Tests/Services/RequestManagement/TransactionMgr/* | Updated all PrepareAck occurrences to UncommittedPrepareChased and CommitAck to CommitChased across various transaction test scenarios. |
| src/KurrentDB.Core.Tests/Services/RequestManagement/Service/RequestManagerServiceSpecification.cs | Modified subscriptions to use UncommittedPrepareChased instead of PrepareAck. |
| src/KurrentDB.Core.Tests/Services/RequestManagement/RequestManagerSpecification.cs | Adjusted subscription for the new prepare message type. |
| src/KurrentDB.Core.Tests/Services/IndexCommitter/* | Revised commit message type from CommitAck to CommitChased in multiple index committer test files. |
Comments suppressed due to low confidence (1)
src/KurrentDB.Core.Tests/Services/IndexCommitter/when_index_commiter_service_receives_replicated_to_prepare_post_position.cs:1
- The filename 'when_index_commiter_service_receives_replicated_to_prepare_post_position.cs' appears to have a typographical error; it should likely be 'when_index_committer_service_receives_replicated_to_prepare_post_position.cs' to match the naming consistency of other files.
Filename: when_index_commiter_service_receives_replicated_to_prepare_post_position.cs
timothycoleman
changed the title
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
shaan1337
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UncommittedPrepareChased is sent by the StorageChaser when it reads uncommitted prepares
CommitChased is sent by the storage chaser when it reads a commit log record or a self committing prepare that ends an implicit transaction