[KDB-916] Add TCP Plugin Configuration Option for TCP read expiry: TcpReadTimeoutMs (#5144) #5165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying eventstore with
|
| Latest commit: |
63f1b43
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a50d2ff1.eventstore.pages.dev |
| Branch Preview URL: | https://cherry-pick-5144-timothycole.eventstore.pages.dev |
timothycoleman
force-pushed
the
cherry-pick/5144/timothycoleman/configurable-tcp-read-expiry-master
branch
from
51a6dbb to
f6a4afe
Compare
timothycoleman
changed the title
timothycoleman
changed the title
Qodana for .NET7 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
timothycoleman
force-pushed
the
cherry-pick/5144/timothycoleman/configurable-tcp-read-expiry-master
branch
from
534a2bb to
bc826a2
Compare
…utMs (#5144) In gRPC this is already driven by the request itself. In TCP we have no such mechanism. We opt for this solution instead of adding it to the TCP protocol to make the change smaller, safer, and easier to roll out while still being useful. This is a forward port of #5144. It's a little bit different because TCP is now in a plugin. I've kept the same option name for simplicity of migration.
timothycoleman
force-pushed
the
cherry-pick/5144/timothycoleman/configurable-tcp-read-expiry-master
branch
from
bc826a2 to
63f1b43
Compare
sakno
approved these changes
Jun 27, 2025
timothycoleman
deleted the
cherry-pick/5144/timothycoleman/configurable-tcp-read-expiry-master
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Server Configuration Option for TCP read expiry: TcpReadTimeoutMs
In gRPC this is already driven by the request itself. In TCP we have no such mechanism. We opt for this solution instead of adding it to the TCP protocol to make the change smaller, safer, and easier to roll out while still being useful.
This is a forward port of #5144. It's a little bit different because TCP is now in a plugin. I've kept the same option name for simplicity of migration.