[KDB-803] Only store non-redundant log record properties #5190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothycoleman
changed the title
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
timothycoleman
force-pushed
the
timothycoleman/properties-metadata-compatibility
branch
2 times, most recently
from
10ca4cf to
6ad23bb
Compare
timothycoleman
force-pushed
the
timothycoleman/properties-metadata-compatibility
branch
4 times, most recently
from
f29b150 to
a5ae98d
Compare
timothycoleman
changed the base branch from
master
to
timothycoleman/do-not-populate-both-metadata-and-properties
timothycoleman
force-pushed
the
timothycoleman/properties-metadata-compatibility
branch
2 times, most recently
from
e38ef42 to
4730ac8
Compare
timothycoleman
changed the title
Base automatically changed from
timothycoleman/do-not-populate-both-metadata-and-properties
to
master
July 21, 2025 13:19
- Do not store EventType as a property, it is stored elsewhere in the log record - Do not store DataFormat as a property when it is fully described by IsJson (i.e. when Json or Bytes) - Reject DataFormats that are not one of the 4 allowed.
timothycoleman
force-pushed
the
timothycoleman/properties-metadata-compatibility
branch
from
4730ac8 to
c511a36
Compare
RagingKore
approved these changes
Jul 21, 2025
| public static class DataFormats { | ||
| // can be others (protobuf, avro, ...) but json is the only one the server cares about | ||
| public const string Json = "json"; | ||
| public const string Bytes = "bytes"; |
There was a problem hiding this comment.
On a future PR we should ensure we use the typed proto enum for the Data Formats.
timothycoleman
deleted the
timothycoleman/properties-metadata-compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log record properties that are already captured elsewhere in the log record need not be stored as properties. They are reconstituted on read.
i.e.
application/jsonorapplication/octet-stream)