-
Notifications
You must be signed in to change notification settings - Fork 668
[DB-1507] Fix authenticated_requests_made_from_a_follower flaky test #5210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
0cd9947
to
4203743
Compare
4203743
to
e57ff40
Compare
e57ff40
to
c5495f7
Compare
The test writes to a follower node which forwards the write to the leader. The reason the test was flaky is that it waits for the admin user to be created on the follower node, but this doesn't guarantee that the user is indexed on the leader. The test fails when the request gets forwarded to the leader but the user isn't yet indexed, at which point the request is rejected. The fix is to wait for the admin user to be created on the leader as part of spinning up the cluster.
c5495f7
to
dc5cd3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 @timothycoleman Failed to create cherry Pick PR due to error:
RequestError [HttpError]: Merge conflict
at /home/runner/work/_actions/kurrent-io/Automations/master/cherry-pick-pr-for-label/node_modules/@octokit/request/dist-node/index.js:66:23
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
status: '409',
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
'content-length': '127',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Fri, 01 Aug 2025 07:53:52 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'github.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'C029:2AA39F:38A3C3:7283CC:688C7290',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4985',
'x-ratelimit-reset': '1754038222',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '15',
'x-xss-protection': '0'
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/kurrent-io/KurrentDB/merges',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-core.js/3.3.2 Node.js/20.19.3 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"base":"cherry-pick-cherry-pick/5210/timothycoleman/flaky-release/v24.10-a6e9adee-25b8-4fd8-8d43-5d8264ddf1ef","commit_message":"Merge dc5cd3abf44afa6d6d36721df857480643c3df3f into cherry-pick-cherry-pick/5210/timothycoleman/flaky-release/v24.10-a6e9adee-25b8-4fd8-8d43-5d8264ddf1ef [skip ci]\\n\\n\\nskip-checks: true\\n","head":"dc5cd3abf44afa6d6d36721df857480643c3df3f"}',
request: { agent: [Agent], hook: [Function: bound bound register] }
},
documentation_url: 'https://docs.github.com/rest/branches/branches#merge-a-branch'
}
🚨👉 Check https://github.com/kurrent-io/KurrentDB/actions/runs/16669592247
The test writes to a follower node which forwards the write to the leader.
The reason the test was flaky is that it waits for the admin user to be created on the follower node, but this doesn't guarantee that the user is indexed on the leader.
The test fails when the request gets forwarded to the leader but the user isn't yet indexed, at which point the request is rejected.
The fix is to wait for the admin user to be created on the leader as part of spinning up the cluster.