Skip to content

Use ISystemClient rather than IPublisher extensions #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2025
Merged

Use ISystemClient rather than IPublisher extensions #5230

merged 3 commits into from
Aug 5, 2025

Conversation

timothycoleman
Copy link
Contributor

Since IPublisher is not specific to client messages.

  • Put IPublisher extensions to do with client messages in their own namespace
  • Swich callers to consume the ISystemClient interface instead
  • Later the IPublisher extensions can be moved to be specific to ISystemClient but I wanted to keep this PR small.

@timothycoleman timothycoleman force-pushed the timothycoleman/use-system-client branch from f494af7 to cb91a20 Compare July 28, 2025 14:23
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 28, 2025 •
edited
Loading

Qodana for .NET

1 new problem were found

Inspection name Severity Problems
Redundant using directive 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@timothycoleman timothycoleman mentioned this pull request Jul 29, 2025
Merged
@timothycoleman timothycoleman force-pushed the timothycoleman/use-system-client branch from cb91a20 to 88692b3 Compare July 29, 2025 11:59
@CLAassistant
Copy link

CLAassistant commented Aug 1, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Base automatically changed from devex-278-schema-registry to master August 1, 2025 08:28
@timothycoleman
Use ISystemClient rather than IPublisher extensions. Put IPublisher e…
d9da28f 
…xtensions in their own namespace, publishers in general don't do anything useful with client messages
@timothycoleman
pass through missed arg
e5e5390
@timothycoleman
if cancelled place the exception into the task rather than throwing s…
64fbdf6 
…ynchronously
@timothycoleman timothycoleman force-pushed the timothycoleman/use-system-client branch from 88692b3 to 64fbdf6 Compare August 1, 2025 08:52
@timothycoleman timothycoleman marked this pull request as ready for review August 1, 2025 08:52
@timothycoleman timothycoleman requested a review from a team as a code owner August 1, 2025 08:52
@timothycoleman timothycoleman mentioned this pull request Aug 1, 2025
Closed
@timothycoleman timothycoleman merged commit 2fb1e59 into master Aug 5, 2025
11 of 14 checks passed
@timothycoleman timothycoleman deleted the timothycoleman/use-system-client branch August 5, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sakno sakno sakno approved these changes

@w1am w1am w1am approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timothycoleman @CLAassistant @sakno @w1am