Add an option to accept bad SSL certificate #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebouthinon
approved these changes
Feb 25, 2021
Aschen
suggested changes
Feb 25, 2021
|
|
||
| ```dart | ||
| HttpProtocol(Uri); | ||
| HttpProtocol(Uri, {bool acceptUnsignedCertificate = false}); |
There was a problem hiding this comment.
Suggested change
| HttpProtocol(Uri, {bool acceptUnsignedCertificate = false}); | |
| HttpProtocol(Uri, {bool acceptBadCertificate = false}); |
There was a problem hiding this comment.
Should be more generic since a certificate can be invalid because of expiry date
Yoann-Abbes
approved these changes
Feb 25, 2021
Aschen
approved these changes
Feb 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add an option to accept bad SSL certificate.