Add-readme-to-vuejs-getting-started #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
suggested changes
Jun 28, 2019
…uejs-getting-started
Codecov Report
@@ Coverage Diff @@
## add-vuejs-getting-started #406 +/- ##
==========================================================
Coverage 96.31% 96.31%
==========================================================
Files 32 32
Lines 1519 1519
==========================================================
Hits 1463 1463
Misses 56 56
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 6-dev #406 +/- ##
=====================================
Coverage 96.3% 96.3%
=====================================
Files 32 32
Lines 1517 1517
=====================================
Hits 1461 1461
Misses 56 56Continue to review full report at Codecov.
|
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Aschen
approved these changes
Jul 1, 2019
xbill82
suggested changes
Jul 1, 2019
Co-Authored-By: Luca Marchesini <xbill82@gmail.com>
…leio/sdk-javascript into add-readme-to-vuejs-getting-started
Co-Authored-By: Luca Marchesini <xbill82@gmail.com>
Co-Authored-By: Luca Marchesini <xbill82@gmail.com>
Co-Authored-By: Luca Marchesini <xbill82@gmail.com>
Co-Authored-By: Luca Marchesini <xbill82@gmail.com>
Co-Authored-By: Luca Marchesini <xbill82@gmail.com>
Co-Authored-By: Luca Marchesini <xbill82@gmail.com>
Co-Authored-By: Luca Marchesini <xbill82@gmail.com>
…eadme-to-vuejs-getting-started
…leio/sdk-javascript into add-readme-to-vuejs-getting-started
…leio/sdk-javascript into add-readme-to-vuejs-getting-started
…leio/sdk-javascript into add-readme-to-vuejs-getting-started
xbill82
approved these changes
Jul 1, 2019
thomasarbona
approved these changes
Jul 1, 2019
|
|
||
| In the _App.vue_ file, you should remove the tag, the import and the component registration of the `HelloWorld` component, we won't use it. | ||
|
|
||
| ## Instanciating Kuzzle SDK |
There was a problem hiding this comment.
better, no?
Suggested change
| ## Instanciating Kuzzle SDK | |
| ## Instanciate Kuzzle SDK |
berthieresteban
added a commit
that referenced
this pull request
Jul 1, 2019
This reverts commit 438cd4b.
Merged
Merged
This was referenced Jul 25, 2019
scottinet
pushed a commit
that referenced
this pull request
Oct 11, 2019
## What does this PR do? This getting-started has been added to the documentation before but removed because vuepress can't build with it. It was approved in those PR : #405 and #406 Add VueJS getting started without vuex to SDK JS6 documentation. Resolve the build problem of the vuepress doc (Vuepress tried to build .vue files of the getting-started and crash) by adding symlink.  :warning: need to add following line in doc/6/getting-started/vuejs/standalone/index.md line 14 after merge: ``` You can find the full code of this guide [here](https://github.com/kuzzleio/sdk-javascript/tree/6-dev/doc/6/getting-started/vuejs/standalone).```:warning: ### How should this be manually tested? See documentation: - Step 1 : npm run doc prepare - Step 2 : npm run doc-dev Test getting started project (You'll need the CYPRESS_RECORD_KEY as environment variable) - Step 1 : Get a Kuzzle running without anonymous restrictions - Step 2 : cd doc/6/getting-started/vuejs && npm ci - Step 3 : npm run serve-standalone - Step 4 : npm run test ### Other changes / ### Boyscout /
scottinet
pushed a commit
that referenced
this pull request
Oct 11, 2019
## What does this PR do? This getting-started has been added to the documentation before but removed because vuepress can't build with it. It was approved in those PR : #405 and #406 Add VueJS getting started without vuex to SDK JS6 documentation. Resolve the build problem of the vuepress doc (Vuepress tried to build .vue files of the getting-started and crash) by adding symlink.  :warning: need to add following line in doc/6/getting-started/vuejs/standalone/index.md line 14 after merge: ``` You can find the full code of this guide [here](https://github.com/kuzzleio/sdk-javascript/tree/6-dev/doc/6/getting-started/vuejs/standalone).```:warning: ### How should this be manually tested? See documentation: - Step 1 : npm run doc prepare - Step 2 : npm run doc-dev Test getting started project (You'll need the CYPRESS_RECORD_KEY as environment variable) - Step 1 : Get a Kuzzle running without anonymous restrictions - Step 2 : cd doc/6/getting-started/vuejs && npm ci - Step 3 : npm run serve-standalone - Step 4 : npm run test ### Other changes / ### Boyscout /
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add readme to vueJS getting started (without vuex)
How should this be manually tested?
/doc/6/getting-started/vuejsfolder of this branch in documentation repo (/src/sdk/js/6/getting-started) without:- node_modules/
- package-lock.json
- /without-vuex/node_modules/
dumpToFile: true,in/src/.vuepress/config.js:exclude: ['/sdk/js/6/getting-started/vuejs/without-vuex/src/**/*'],npm run devOther changes
/
Boyscout
/