-
Notifications
You must be signed in to change notification settings - Fork 17
Add-getting-started-vuejs #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## 6-dev #429 +/- ##
==========================================
- Coverage 96.45% 96.45% -0.01%
==========================================
Files 33 33
Lines 1553 1550 -3
==========================================
- Hits 1498 1495 -3
Misses 55 55
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 6-dev #429 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 33 33
Lines 1556 1556
=======================================
Hits 1502 1502
Misses 54 54 Continue to review full report at Codecov.
|
…avascript into poc-getting-started-vuejs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of putting your getting started app at repository root you can put it in the documentation folder with a hidden directory.
I tried to put the sources in doc/6/getting-started...without-vuex/.src/
and the build is ok
Also why do you need to create the symlink in doc.sh
? It's better for maintainability to keep this script as small as possible
…avascript into poc-getting-started-vuejs
…avascript into poc-getting-started-vuejs
…etting-started-vuejs
What does this PR do?
This getting-started has been added to the documentation before but removed because vuepress can't build with it.
It was approved in those PR : #405 and #406
Add VueJS getting started without vuex to SDK JS6 documentation.
Resolve the build problem of the vuepress doc (Vuepress tried to build .vue files of the getting-started and crash) by adding symlink.
You can find the full code of this guide [here](https://github.com/kuzzleio/sdk-javascript/tree/6-dev/doc/6/getting-started/vuejs/standalone).
How should this be manually tested?
See documentation:
Test getting started project (You'll need the CYPRESS_RECORD_KEY as environment variable)
Other changes
/
Boyscout
/