Remove local checks for arguments #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #450 +/- ##
========================================
- Coverage 96.07% 96% -0.08%
========================================
Files 33 33
Lines 1630 1350 -280
========================================
- Hits 1566 1296 -270
+ Misses 64 54 -10
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging 879b67b into 9a82451 - view on LGTM.com new alerts:
|
xbill82
approved these changes
Oct 11, 2019
scottinet
pushed a commit
that referenced
this pull request
Oct 11, 2019
## What does this PR do? `v6` version of #450 Remove the local check of the arguments since now we have specifics errors code sent by Kuzzle. ### Other changes - Add error codes `id` and `code` properties to `KuzzleError`
scottinet
suggested changes
Oct 15, 2019
scottinet
approved these changes
Oct 15, 2019
Merged
Aschen
added a commit
that referenced
this pull request
Nov 5, 2019
# [7.0.0-beta.2](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.0.0-beta.2) (2019-11-05) #### Bug fixes - [ [#453](#453) ] Fix connected property ([Aschen](https://github.com/Aschen)) #### Enhancements - [ [#450](#450) ] Remove local checks for arguments ([Aschen](https://github.com/Aschen)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the local check of the arguments since now we have specifics errors code sent by Kuzzle.
Other changes
idandcodeproperties toKuzzleErrorsdkNameandsdkInstanceIdin the volatile