7.0.0 beta.2 proposal #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description The current [SearchResult](https://docs.kuzzle.io/sdk/js/6/core-classes/search-result) documentation contains inconsistencies, spelling errors, and the comments in the snippet examples are off. Also, the introduction page seems overkill for that class. This PR rewrites most of that documentation.
## What does this PR do? The `kuzzle.connected` property which delegate to the protocol was testing a wrong `protocol.state` value (`'online'` instead of `'connected'`).
# Description Import #431 and #436 to v7: commits were cherry-picked, then the getting started directories were moved to the `doc/7` documentation directory. Finally, the `test-doc` script has been adapted to run tests on the v7 version of the getting started. Those are the only changes made, there should be no need to review the full content of this PR (but you may do it if you want to)
## What does this PR do? Remove the local check of the arguments since now we have specifics errors code sent by Kuzzle. ### Other changes - Add `id` and `code` properties to `KuzzleError` - Allow custom `sdkName` and `sdkInstanceId` in the volatile
Codecov Report
@@ Coverage Diff @@
## 7-beta #458 +/- ##
=======================================
Coverage ? 96%
=======================================
Files ? 33
Lines ? 1350
Branches ? 0
=======================================
Hits ? 1296
Misses ? 54
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.0.0-beta.2 (2019-11-05)
Bug fixes
Enhancements