Import Vue.js and React getting started from v6 #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What does this PR do? This getting-started has been added to the documentation before but removed because vuepress can't build with it. It was approved in those PR : #405 and #406 Add VueJS getting started without vuex to SDK JS6 documentation. Resolve the build problem of the vuepress doc (Vuepress tried to build .vue files of the getting-started and crash) by adding symlink.  :warning: need to add following line in doc/6/getting-started/vuejs/standalone/index.md line 14 after merge: ``` You can find the full code of this guide [here](https://github.com/kuzzleio/sdk-javascript/tree/6-dev/doc/6/getting-started/vuejs/standalone).```:warning: ### How should this be manually tested? See documentation: - Step 1 : npm run doc prepare - Step 2 : npm run doc-dev Test getting started project (You'll need the CYPRESS_RECORD_KEY as environment variable) - Step 1 : Get a Kuzzle running without anonymous restrictions - Step 2 : cd doc/6/getting-started/vuejs && npm ci - Step 3 : npm run serve-standalone - Step 4 : npm run test ### Other changes / ### Boyscout /
## What does this PR do? Add Kuzzle React getting-started. This getting-started have been merge in the last doc [#291](kuzzleio/documentation#291) The last getting started app was builted progressively and some code was rewrite during the reading. I had to rewrite lot of parts to remove that because it implicated some untested lines. I avoid hard snippets written in the readme too. I removed the tested snippets and add cypress to test the app globally. The app use the current 6-dev sdk version with the ugly post-install line in `doc/6/getting-started/.react/package.json` ### How should this be manually tested? - Step 0 : Kuzzle running stack - Step 1 : cd doc/6/getting-started/.react - Step 2 : yarn install - Step 3 : yarn start & (if error add `SKIP_PREFLIGHT_CHECK=true`) - Step 4 : npm run test ### Other changes / ### Boyscout /
Aschen
approved these changes
Oct 14, 2019
alexandrebouthinon
approved these changes
Oct 14, 2019
|
Test will be fixed in a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Import #431 and #436 to v7: commits were cherry-picked, then the getting started directories were moved to the
doc/7documentation directory. Finally, thetest-docscript has been adapted to run tests on the v7 version of the getting started.Those are the only changes made, there should be no need to review the full content of this PR (but you may do it if you want to)