Do not try to reconnect if the browser is offline #455
+1,203
−324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #455 +/- ##
=========================================
+ Coverage 96% 96.01% +0.01%
=========================================
Files 33 33
Lines 1350 1355 +5
=========================================
+ Hits 1296 1301 +5
Misses 54 54
Continue to review full report at Codecov.
|
Aschen
approved these changes
Nov 4, 2019
Yoann-Abbes
approved these changes
Nov 7, 2019
Merged
Aschen
added a commit
that referenced
this pull request
Nov 21, 2019
# [7.0.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.0.0) (2019-11-20) #### Bug fixes - [ [#464](#464) ] Fix option refresh in queries ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#463](#463) ] Fix erroneous error message on browser ws error ([scottinet](https://github.com/scottinet)) #### Enhancements - [ [#455](#455) ] Do not try to reconnect if the browser is offline ([scottinet](https://github.com/scottinet)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
autoReconnectis true, the SDK tries to reconnect everyreconnectionDelaymilliseconds.If executed within a browser, the SDK can know if the browser has access to some kind of network: if it's marked as "offline", then there is no point retrying to connect, and this might even be harmful in some situations. For instance, browsers switch to offline if a laptop lid is closed, or if a mobile phone screen is turned off. So continuing to connect is just a useless consumption of battery power.
This PR stops the reconnection loop and instead waits for the browser to switch to "online" again before resuming its reconnection attempts.