Fix erroneous error message on browser ws error #463
Merged
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
approved these changes
Nov 13, 2019
alexandrebouthinon
approved these changes
Nov 14, 2019
jenow
approved these changes
Nov 14, 2019
Aschen
force-pushed
the
7/fix-ws-error-message
branch
from
16cb507 to
fb0388e
Compare
Codecov Report
@@ Coverage Diff @@
## 7-dev #463 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 33 33
Lines 1355 1355
=======================================
Hits 1301 1301
Misses 54 54
Continue to review full report at Codecov.
|
Merged
Aschen
added a commit
that referenced
this pull request
Nov 21, 2019
# [7.0.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.0.0) (2019-11-20) #### Bug fixes - [ [#464](#464) ] Fix option refresh in queries ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#463](#463) ] Fix erroneous error message on browser ws error ([scottinet](https://github.com/scottinet)) #### Enhancements - [ [#455](#455) ] Do not try to reconnect if the browser is offline ([scottinet](https://github.com/scottinet)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
onerrorevent handler called in browsers' WebSocket API differ from the one exposed by thewsmodule used in Node.js: the handler in browsers receive a genericEventobject without any error information, while the ws handler receives a proper error.Result:
kuzzle.connect().catch(e => console.log(e))prints something likeError: [object Event]in a browser's console.This PR fixes that issue by detecting the case and sending a generic
Connection errorto the connect promise handler.How to reproduce
Run the following script in a browser:
Without this PR, the console should show the following message:
Error: [object Event]With this PR:
Error: Connection error