Fix option refresh in queries #464
Merged
+201
−954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #464 +/- ##
==========================================
- Coverage 96.01% 95.96% -0.06%
==========================================
Files 33 33
Lines 1355 1338 -17
==========================================
- Hits 1301 1284 -17
Misses 54 54
Continue to review full report at Codecov.
|
Yoann-Abbes
changed the title
scottinet
suggested changes
Nov 15, 2019
src/controllers/collection.js
Outdated
| action: 'create', | ||
| refresh: options.refresh | ||
| }; | ||
| delete options.refresh; |
There was a problem hiding this comment.
..why, since now Kuzzle.query handles the refresh option?
It seems to me that you don't need to change controllers to fix the issue.
There was a problem hiding this comment.
I changed the way it fix the issue in the last commit
scottinet
suggested changes
Nov 19, 2019
test/controllers/collection.test.js
Outdated
| index: 'index', | ||
| collection: 'collection' | ||
| collection: 'collection', | ||
| refresh: undefined |
alexandrebouthinon
approved these changes
Nov 19, 2019
Aschen
suggested changes
Nov 20, 2019
src/Kuzzle.js
Outdated
| if (request.refresh) { | ||
| if (request.refresh || options.refresh) { | ||
| if (options.refresh) { | ||
| delete options.refresh; |
There was a problem hiding this comment.
Why do you delete the property after using it?
It can be confusing to mutate the original object, it could be reused for subsequent calls:
const options = { refresh: 'wait_for' };
sdk.query({...}, options);
sdk.query({...}, options); // options object have been mutated
Merged
Aschen
added a commit
that referenced
this pull request
Nov 21, 2019
# [7.0.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.0.0) (2019-11-20) #### Bug fixes - [ [#464](#464) ] Fix option refresh in queries ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#463](#463) ] Fix erroneous error message on browser ws error ([scottinet](https://github.com/scottinet)) #### Enhancements - [ [#455](#455) ] Do not try to reconnect if the browser is offline ([scottinet](https://github.com/scottinet)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the way we pass the
refreshoption in several routes.Before that, the option was lost and never passed to ES.
Ticket Jira
How should this be manually tested?
...
Other changes
Boyscout