Skip to content
This repository was archived by the owner on Nov 21, 2019. It is now read-only.

change header color, primary buttons, and top border to green for ETC#718

Closed
willpiers wants to merge 2 commits intoMyEtherWallet:mercuryfrom
willpiers:v3.9.x--ETC-colors
Closed

change header color, primary buttons, and top border to green for ETC#718
willpiers wants to merge 2 commits intoMyEtherWallet:mercuryfrom
willpiers:v3.9.x--ETC-colors

Conversation

@willpiers
Copy link
Copy Markdown

These changes were made in response to an ETC Bounty

This PR updates header, top border, and all primary buttons to reflect that the user is interacting with the ETC node.

screen shot 2017-07-09 at 7 16 27 pm

@willpiers
Copy link
Copy Markdown
Author

The only files I changed were header.tpl, index.html, viewCtrl.js, and etherwallet-custom.less

Not sure if I was supposed to commit the rest. Let me know and I will make another PR to add clarifying info to the README

<body>

<header class="{{curNode.name}} {{curNode.service}} {{curNode.service}} nav-index-{{gService.currentTab}}" aria-label="header" ng-controller='tabsCtrl' >
<header class="{{curNode.name}} {{curNode.service}} nav-index-{{gService.currentTab}}" aria-label="header" ng-controller='tabsCtrl' >
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just looked unnecessary to me, so I removed it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - is unnecessary.

.container.ETC {
.btn.btn-primary {
border: none;
background-color: #3DB753;
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as @brand-etc - I'll push a change

@tayvano
Copy link
Copy Markdown
Contributor

tayvano commented Jul 24, 2017

FYI - Cody's got this in v3.10 which I aim to test tonight and deploy tomorrow.

@willpiers
Copy link
Copy Markdown
Author

willpiers commented Jul 24, 2017

Awesome, looking forward to it. Make sure Cody claims the bounty!

@Dexaran
Copy link
Copy Markdown

Dexaran commented Jul 27, 2017

No one has claimed the bounty yet. You've did exactly what I was talking about. I'm ready to pay the bounty reward as soon as changes would appear at the web version of MEW.

@Dexaran
Copy link
Copy Markdown

Dexaran commented Aug 5, 2017

Spotted a mistake. Button color doesn't change when you switch the node.

@alexbarnsley
Copy link
Copy Markdown

@Dexaran want me to take a look at your last comment as it's been over a month?

@kvhnuke
Copy link
Copy Markdown
Collaborator

kvhnuke commented Feb 20, 2018

I believe this is outdated, please open a new PR

@kvhnuke kvhnuke closed this Feb 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants