Merged
Conversation
Depending on the commands used in your `query.sql` the `copyfrom.go` may end up with unused packge imports. There is a patch for this problem that was merged in the sqlc-dev#1386 PR. However, it looks like some edge cases were left out of the fix. This commit ensures that `buildImports` only has `copyfrom` queries when called from `copyfromImports`.
positiveblue
commented
May 17, 2022
| -- name: InsertSingleValue :exec | ||
| INSERT INTO myschema.foo (a) VALUES ($1); | ||
|
|
||
| -- name: DeleteValues :execresult |
Author
There was a problem hiding this comment.
This was the main offender, any file generated from a query file with queries of type metadata.CmdExecResult would include the github.com/jackc/pgconn package
kyleconroy
approved these changes
May 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on the commands used in your
query.sqlthecopyfrom.gomay end up with unused package imports.
There is a patch for this problem that was merged in the #1386 PR.
However, it looks like some edge cases were left out of the fix.
This commit ensures that
buildImportsonly hascopyfromquerieswhen called from
copyfromImports.