Skip to content

Conversation

@E-Rum
Copy link
Contributor

@E-Rum E-Rum commented Apr 30, 2025

Contributor (creator of pull-request) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

Reviewer checklist

  • CHANGELOG updated with public API or any other important changes?

📚 Documentation preview 📚: https://torch-pme--184.org.readthedocs.build/en/184/

@E-Rum E-Rum requested a review from PicoCentauri May 5, 2025 10:33
Copy link
Contributor

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug? Meaning that the exclusion was not working before?

@E-Rum
Copy link
Contributor Author

E-Rum commented May 5, 2025

Yes, it wasn't working before

@PicoCentauri
Copy link
Contributor

wonderful! Can you add a test and update the changelog?

@E-Rum
Copy link
Contributor Author

E-Rum commented May 5, 2025

Yes! Will do as soon as we merge #183

@E-Rum E-Rum force-pushed the exclude_direct branch from 926b30e to 80fbb1b Compare May 15, 2025 09:43
@E-Rum E-Rum requested a review from PicoCentauri May 15, 2025 11:03
@E-Rum E-Rum merged commit f3a67b6 into main Jun 2, 2025
13 checks passed
@E-Rum E-Rum deleted the exclude_direct branch June 2, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants