[WIP] Topic/completion #19
Conversation
|
|
||
| case "$prev" in | ||
| -p) | ||
| COMPREPLY=( $( compgen -W "$(labgrid-client complete places)" -- $cur ) ) |
There was a problem hiding this comment.
maybe cache the list in a global variable and only rerun the command if COMPREPLY is empty?
| release\ | ||
| env\ | ||
| power\ | ||
| console" -- $cur ) ) |
There was a problem hiding this comment.
This list should be generated. Either from parsing labgrid-client -h or new new labgrid-client complete commands. Otherwise this is always out of date. Just cache the list in a global variable to speed things up.
| # completing an option | ||
| if [[ "$cur" == -* ]]; then | ||
| COMPREPLY=( $( compgen -W "-p -h -x" -- $cur ) ) | ||
| else |
There was a problem hiding this comment.
No need to split things up here. compgen will filter thing correctly depending on $cur.
Emantor
force-pushed
the
topic/completion
branch
from
86f45d4 to
f94fdd4
Compare
1 similar comment
Emantor
force-pushed
the
topic/completion
branch
3 times, most recently
from
65e5c34 to
1112993
Compare
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Add filter support to complete command: -m, --mine places/resources acquired by the local client -a, --acquired places/resources acquired by all clients
Emantor
force-pushed
the
topic/completion
branch
from
1112993 to
bb2a8f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
========================================
- Coverage 56.5% 56.4% -0.2%
========================================
Files 77 77
Lines 3440 3450 +10
========================================
+ Hits 1947 1949 +2
- Misses 1493 1501 +8
Continue to review full report at Codecov.
|
|
Closing this for now. |
|
Oh, why was this abandoned? I think shell completion for labgrid-client would be a great feature. |
5 participants
TODO: