Skip to content

Conversation

@nefethael
Copy link
Contributor

Signed-off-by: Vincent Prince vincent.prince.fr@gmail.com

@codecov-io
Copy link

codecov-io commented May 18, 2018

Codecov Report

Merging #242 into master will decrease coverage by <.1%.
The diff coverage is 31.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #242     +/-   ##
========================================
- Coverage    58.1%   58.1%   -0.1%     
========================================
  Files         114     114             
  Lines        7040    7056     +16     
========================================
+ Hits         4097    4102      +5     
- Misses       2943    2954     +11
Impacted Files Coverage Δ
labgrid/protocol/commandprotocol.py 100% <100%> (ø) ⬆️
labgrid/driver/commandmixin.py 58.9% <21.4%> (-21.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc944f3...db15cc8. Read the comment docs.

Emantor
Emantor previously approved these changes May 18, 2018
@nefethael
Copy link
Contributor Author

I removed try catch as it was useless.

Emantor
Emantor previously approved these changes May 31, 2018
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, however we are still missing documentation for this feature.

@Emantor Emantor dismissed their stale review June 4, 2018 08:00

No Documentation provided

Copy link
Member

@jluebbe jluebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs documentation at least for the parameters.

@Emantor
Copy link
Member

Emantor commented Nov 12, 2018

The documentation strings have been updated by me, please review again so we can get this merged.

@Emantor
Copy link
Member

Emantor commented Nov 21, 2018

@jluebbe please take a look at this again, should be ready to go.

@jluebbe
Copy link
Member

jluebbe commented Jan 2, 2019

I've fixed the return values and rebased the changes.

jluebbe
jluebbe previously approved these changes Jan 2, 2019
nefethael and others added 2 commits February 22, 2019 12:28
Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
Add the documentation strings for poll_until_success and wait_for

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
@Emantor
Copy link
Member

Emantor commented Feb 22, 2019

I rebased again and resolved the conflicts, I'll wait for a CI run and than merge.

@Emantor Emantor merged commit 269c386 into labgrid-project:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants