-
Notifications
You must be signed in to change notification settings - Fork 232
driver/commandmixin: Add poll_until_success helper function #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
driver/commandmixin: Add poll_until_success helper function #242
Conversation
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
========================================
- Coverage 58.1% 58.1% -0.1%
========================================
Files 114 114
Lines 7040 7056 +16
========================================
+ Hits 4097 4102 +5
- Misses 2943 2954 +11
Continue to review full report at Codecov.
|
|
I removed try catch as it was useless. |
Emantor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, however we are still missing documentation for this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but needs documentation at least for the parameters.
|
The documentation strings have been updated by me, please review again so we can get this merged. |
|
@jluebbe please take a look at this again, should be ready to go. |
|
I've fixed the return values and rebased the changes. |
Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
Add the documentation strings for poll_until_success and wait_for Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
|
I rebased again and resolved the conflicts, I'll wait for a CI run and than merge. |
Signed-off-by: Vincent Prince vincent.prince.fr@gmail.com