[RDY] Topic/onewire #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
jluebbe
requested changes
Feb 28, 2017
labgrid/protocol/OneWireProtocol.py
Outdated
| import abc | ||
|
|
||
|
|
||
| class OneWireProtocol(abc.ABC): |
Member
There was a problem hiding this comment.
At the protocol level, this should be more generic. Maybe call it DigitalOutput instead?
labgrid/driver/onewiredriver.py
Outdated
|
|
||
| @target_factory.reg_driver | ||
| @attr.s | ||
| class OneWireDriver(Driver): |
Member
There was a problem hiding this comment.
Corresponding to the change to the Protocol, this should be a OneWirePIODriver, implementing the DigitalOutput protocol.
labgrid/driver/powerdriver.py
Outdated
|
|
||
| @target_factory.reg_driver | ||
| @attr.s | ||
| class OneWirePowerDriver(Driver, PowerProtocol): |
Member
There was a problem hiding this comment.
This would be called DigitalOutputPowerDriver.
labgrid/resource/onewireport.py
Outdated
| @attr.s | ||
| class OneWirePort(Resource): | ||
| portname = attr.ib(validator=attr.validators.instance_of(str)) | ||
| url = attr.ib(validator=attr.validators.instance_of(str)) |
Member
There was a problem hiding this comment.
This should be called OneWirePIO and have host and path properties. Also add a docstring giving an example path.
Emantor
force-pushed
the
topic/onewire
branch
8 times, most recently
from
35a3e22 to
1417ad0
Compare
1 similar comment
Emantor
force-pushed
the
topic/onewire
branch
2 times, most recently
from
5c0dd91 to
7984b0d
Compare
Emantor
force-pushed
the
topic/onewire
branch
3 times, most recently
from
facdfa7 to
204c33a
Compare
Member
Author
|
This should be ready for review now, removing WIP. |
jluebbe
requested changes
Mar 2, 2017
labgrid/driver/powerdriver.py
Outdated
| @target_factory.reg_driver | ||
| @attr.s | ||
| class DigitalOutputPowerDriver(Driver, PowerProtocol): | ||
| """NetworkPowerDriver - Driver using a networked power switch to control a target's power""" |
labgrid/driver/powerdriver.py
Outdated
| @attr.s | ||
| class DigitalOutputPowerDriver(Driver, PowerProtocol): | ||
| """NetworkPowerDriver - Driver using a networked power switch to control a target's power""" | ||
| bindings = {"onewire": OneWirePIODriver, } |
Member
There was a problem hiding this comment.
Shouldn't this bind to a DigitalOutputProtocol? Maybe use "output" as the name.
|
|
||
| @target_factory.reg_resource | ||
| @attr.s | ||
| class OneWirePIO(Resource): |
Member
There was a problem hiding this comment.
Add a docstring with example host/port values.
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
jluebbe
approved these changes
Mar 2, 2017
benjamin1313
pushed a commit
to benjamin1313/labgrid
that referenced
this pull request
Feb 19, 2025
remote/client: support token with template RemotePlace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add onewire support to labgrid, needs a running onewire server at the moment.
WIP: