Skip to content

Conversation

@Emantor
Copy link
Member

@Emantor Emantor commented Feb 28, 2017

Remove labgrid/protocols/* from coverage.

@Emantor Emantor requested a review from jluebbe February 28, 2017 06:44
@Emantor Emantor assigned Emantor and unassigned Emantor Feb 28, 2017
@coveralls
Copy link

coveralls commented Feb 28, 2017

Coverage Status

Coverage decreased (-0.3%) to 47.857% when pulling 0d4a9af on Emantor:fix/coverage_setup into 71c65b0 on labgrid-project:master.

Copy link
Member

@jluebbe jluebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All protocol classes are abstract interfaces which are do not need to be covered
by tests. Exclude them in .coveragerc and use it during the travis run.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
@Emantor Emantor changed the title coveralls: exclude protocols via .coveragerc and use it for travis coveralls: exclude lines via .coveragerc and use it for travis Feb 28, 2017
@Emantor
Copy link
Member Author

Emantor commented Feb 28, 2017

I updated the branch to only ignore the suggested lines from here, should be ready to merge now.

@coveralls
Copy link

coveralls commented Feb 28, 2017

Coverage Status

Coverage increased (+0.6%) to 48.815% when pulling 13907b5 on Emantor:fix/coverage_setup into 71c65b0 on labgrid-project:master.

@jluebbe jluebbe merged commit e077cf5 into labgrid-project:master Feb 28, 2017
@Emantor Emantor deleted the fix/coverage_setup branch March 1, 2017 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants