Skip to content

Conversation

@Bastian-Krause
Copy link
Member

@Bastian-Krause Bastian-Krause commented Oct 5, 2021

Description
Test/announce Python 3.10 compatibility.

Checklist

  • CHANGES.rst has been updated
  • PR has been tested

Introduces deprecation warnings (see CI job):

tests/test_crossbar.py::test_remoteplace_target
  /home/runner/work/labgrid/labgrid/labgrid/remote/client.py:33: DeprecationWarning: There is no current event loop
    txaio.config.loop = asyncio.get_event_loop()

tests/test_crossbar.py::test_remoteplace_target
  /home/runner/work/labgrid/labgrid/labgrid/remote/client.py:1334: DeprecationWarning: There is no current event loop
    loop = asyncio.get_event_loop()

tests/test_crossbar.py::test_remoteplace_target
  /opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/autobahn/asyncio/websocket.py:300: DeprecationWarning: There is no current event loop
    self.loop = loop or asyncio.get_event_loop()

tests/test_crossbar.py::test_remoteplace_target
  /opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/autobahn/asyncio/wamp.py:238: DeprecationWarning: There is no current event loop
    loop = asyncio.get_event_loop()

tests/test_ethernetport.py::test_instance
  /home/runner/work/labgrid/labgrid/labgrid/resource/ethernetport.py:251: DeprecationWarning: There is no current event loop
    self.loop = asyncio.get_event_loop()

tests/test_powerdriver.py::TestNetworkPowerDriver::test_import_backends
  /opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/site-packages/pysnmp/carrier/asyncore/base.py:9: DeprecationWarning: The asyncore module is deprecated. The recommended replacement is asyncio
    import asyncore

The event loop should now be created/set explicitly.

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #848 (60004e9) into master (b97c44c) will increase coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 60004e9 differs from pull request most recent head fd2c97a. Consider uploading reports for the commit fd2c97a to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##           master    #848   +/-   ##
======================================
  Coverage    56.6%   56.7%           
======================================
  Files         145     145           
  Lines       10741   10739    -2     
======================================
+ Hits         6090    6091    +1     
+ Misses       4651    4648    -3     
Impacted Files Coverage Δ
labgrid/util/agents/sysfsgpio.py 83.9% <0.0%> (-0.9%) ⬇️
labgrid/config.py 81.8% <0.0%> (-0.6%) ⬇️
labgrid/resource/docker.py 97.4% <0.0%> (+<0.1%) ⬆️
labgrid/resource/remote.py 83.3% <0.0%> (+<0.1%) ⬆️
labgrid/remote/common.py 86.7% <0.0%> (+0.5%) ⬆️
labgrid/strategy/shellstrategy.py 38.0% <0.0%> (+0.7%) ⬆️
labgrid/strategy/bareboxstrategy.py 45.2% <0.0%> (+1.0%) ⬆️
labgrid/strategy/ubootstrategy.py 43.5% <0.0%> (+1.0%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b97c44c...fd2c97a. Read the comment docs.

@Bastian-Krause
Copy link
Member Author

Rebased on current master.

Signed-off-by: Bastian Krause <bst@pengutronix.de>
Signed-off-by: Bastian Krause <bst@pengutronix.de>
@Bastian-Krause
Copy link
Member Author

Rebased again.

@Emantor
Copy link
Member

Emantor commented Oct 8, 2021

Any reason why this is still a draft?

@Bastian-Krause
Copy link
Member Author

Any reason why this is still a draft?

I thought we'd fix the DeprecationWarnings we cause first, see PR description.

@jluebbe
Copy link
Member

jluebbe commented Oct 11, 2021

Any reason why this is still a draft?

I thought we'd fix the DeprecationWarnings we cause first, see PR description.

As the tests work correctly, fixing the deprecation warnings (which affect autobahn and pysnmp as well) can be done in a different PR.

@Bastian-Krause Bastian-Krause marked this pull request as ready for review October 11, 2021 07:57
@Emantor Emantor merged commit 35f534a into labgrid-project:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants