remote/client: fix forwarding of remote ports #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'labgrid-client forward --remote' accidentally uses the variable 'localport', which is either not set at all (leading to a UnboundLocalError) if no --local/-L is set or is set to the LOCAL part of --local/-L, which is wrong. The LOCAL part of --remote/-R should be used instead. Fix that by using the correct variable 'local'. Note that the informational print used the correct variable already. Fixes: 51f3fe5 ("client: Add port forwarding") Signed-off-by: Bastian Krause <bst@pengutronix.de>
Member
Author
|
@JoshuaWatt Could you take a look? |
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
======================================
Coverage 56.9% 56.9%
======================================
Files 145 145
Lines 10854 10854
======================================
Hits 6179 6179
Misses 4675 4675
Continue to review full report at Codecov.
|
Contributor
|
LGTM; sorry about that! |
Bastian-Krause
requested review from
Emantor and
SmithChart
and removed request for
SmithChart
Emantor
previously approved these changes
Oct 20, 2021
Emantor
approved these changes
Oct 20, 2021
Bastian-Krause
removed
the
pick to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
labgrid-client forward --remoteaccidentally uses the variablelocalport, which is either not set at all (leading to aUnboundLocalError) if no--local/-Lis set or is set to theLOCALpart of--local/-L, which is wrong. TheLOCALpart of--remote/-Rshould be used instead.Fix that by using the correct variable
local.Note that the informational print used the correct variable already.
Checklist
Fixes #751