remote/client: update resources before checking NetworkSerialPort availability #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilability PR labgrid-project#935 added async waiting for the NetworkSerialPort. This makes `labgrid-client console --loop` work as long as the resource changes from being unavailable to being available. It does not work vice versa, however: the resources are not being updated before being checked for availability. The code inside the while loop does not run in this case. This makes the subsequent `target.await_resources()` raise a NoResourceFoundError which is not handled anywhere causing an error message and exit of labgrid-client despite being called with ``--loop``. Fix that by updating the resources before checking the resource's availability. `labgrid-client console --loop` will now loop even if the NetworkSerialPort changes from being available to unavailable. Fixes: 2230536 ("remote/client: no block in async console, loop even on unavailable resource") Signed-off-by: Bastian Krause <bst@pengutronix.de>
Member
Author
|
@khilman Could you give this a test? |
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
========================================
- Coverage 57.2% 57.1% -0.1%
========================================
Files 150 150
Lines 11192 11194 +2
========================================
Hits 6402 6402
- Misses 4790 4792 +2
Continue to review full report at Codecov.
|
Emantor
approved these changes
Jun 22, 2022
Member
Author
Contributor
|
Works great now, thank you! Tested-by: Kevin Hilman khilman@baylibre.com |
Member
Author
|
Nice, thanks for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #935 added async waiting for the NetworkSerialPort. This makes
labgrid-client console --loopwork as long as the resource changes from being unavailable to being available. It does not work vice versa, however: the resources are not being updated before being checked for availability. The code inside the while loop does not run in this case.This makes the subsequent
target.await_resources()raise a NoResourceFoundError which is not handled anywhere causing an error message and exit of labgrid-client despite being called with--loop.Fix that by updating the resources before checking the resource's availability.
labgrid-client console --loopwill now loop even if the NetworkSerialPort changes from being available to unavailable.Checklist
Fixes #935
Fixes #926