sshdriver: Fix timeout for run() #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
======================================
Coverage 57.2% 57.2%
======================================
Files 150 150
Lines 11192 11192
======================================
Hits 6402 6402
Misses 4790 4790
Continue to review full report at Codecov.
|
Bastian-Krause
requested changes
Jun 23, 2022
Member
Bastian-Krause
left a comment
Bastian-Krause
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks good, one minor improvement, though.
The run() function was not passing its timeout parameter on to the internal _run() function; therefore, any timeout set by a caller was ignored. Signed-off-by: Nick Potenski <nick.potenski@garmin.com>
Bastian-Krause
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The run() function was not passing its timeout parameter on to the
internal _run() function; therefore, any timeout set by a caller was
ignored.
Signed-off-by: Nick Potenski nick.potenski@garmin.com
Description
Checklist