-
Notifications
You must be signed in to change notification settings - Fork 229
driver/qemudriver: add drive interface and kernel boot parameters #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
========================================
- Coverage 57.1% 57.1% -0.1%
========================================
Files 150 150
Lines 11202 11203 +1
========================================
Hits 6402 6402
- Misses 4800 4801 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
086ba3b to
185bf11
Compare
jluebbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect that you'd need if=virtio to get root=/dev/vda to work.
185bf11 to
26507a4
Compare
You're right. Let's keep the interface out for now. I rewrote the commit message to reflect this change. |
|
Does it work this way? You said that q35 defaults to IDE in #961 (comment). My preferred approach would be |
|
In my case, I am using a bios image ( |
|
Ah. You could not set the |
…machine Signed-off-by: Emil Kronborg Andersen <emil.kronborg@protonmail.com>
26507a4 to
63560b7
Compare
|
OK. That solution is not as elegant as using the |
|
Thanks a lot for your contribution! |
Description
Make the
q35machine behave similar topcif a kernel is started directly. Furthermore, the default drive interface has been added. This commit is an addition to086ba3b3fe1e04bcc8cba0e6dfe558b7747d372d.Checklist