driver/qemudriver: fix disk attribute for vexpress-a9 machine #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the q35 machine was added, using the vexpress-a9 machine with a disk attribute ends up with a NotImplementedError. Fix that. Fixes: 9bdacb2 ("driver/qemudriver: add support for Q35 machine") Signed-off-by: Bastian Krause <bst@pengutronix.de>
Emantor
approved these changes
Aug 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
======================================
Coverage 61.8% 61.8%
======================================
Files 150 150
Lines 11203 11203
======================================
Hits 6929 6929
Misses 4274 4274
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jluebbe
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the q35 machine was added, using the vexpress-a9 machine with a disk attribute ends up with a
NotImplementedError. Fix that.Checklist
Fixes #961