Skip to content

Conversation

gary-Shen
Copy link
Contributor

No description provided.

Copy link

cla-assistant bot commented Sep 9, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Sep 9, 2025

Preview Image Label

Preview Images for this PR are:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-plugin-pr:87ced9c5bd23c90218361498cad3bb3793094921

@gary-Shen gary-Shen marked this pull request as ready for review September 9, 2025 10:53
@FinleyGe
Copy link
Collaborator

为什么要分本地部署和官方两个工具呢?传入不同的 base_url 和 key 就行了吧

@gary-Shen
Copy link
Contributor Author

其实是为了区分本地部署和官方API的参数,合并在一起的话,有些参数是多余的。

本地部署的代码并不多,我考虑看看要不要合在一起吧。

@gary-Shen
Copy link
Contributor Author

gary-Shen commented Sep 10, 2025

为什么要分本地部署和官方两个工具呢?传入不同的 base_url 和 key 就行了吧

权衡了一下,两个方法的配置还是不太一样的,为了保证最佳的使用体验,还是保持分开两个工具:

image

更新了一下工具文案:

image

@gary-Shen
Copy link
Contributor Author

@FinleyGe 老哥再 review 看看?

@c121914yu c121914yu requested a review from Copilot September 11, 2025 13:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the MinerU document parsing tool integration to the project, providing both SaaS and locally deployed parsing capabilities for various document formats including PDF, DOC, DOCX, PPT, PPTX, and images.

  • Adds a new tool package for MinerU document parsing with comprehensive configuration options
  • Implements two parsing methods: remote SaaS service and local deployment API
  • Provides extensive language support and customizable parsing features

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
modules/tool/packages/mineru/package.json Package configuration with dependencies for JSZip and Zod
modules/tool/packages/mineru/index.ts Main export entry point for the tool set
modules/tool/packages/mineru/config.ts Tool set configuration with metadata and secret inputs
modules/tool/packages/mineru/children/parseRemote/* Remote SaaS parsing implementation with full API integration
modules/tool/packages/mineru/children/parseLocal/* Local deployment parsing implementation using API v2

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gary-Shen gary-Shen marked this pull request as draft September 11, 2025 14:39
@gary-Shen gary-Shen marked this pull request as ready for review September 12, 2025 03:35
@gary-Shen
Copy link
Contributor Author

@c121914yu Ready for review.

@FinleyGe FinleyGe merged commit 0c4c10e into labring:main Sep 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants