set forwarded-proto header for proxy targets on incoming https requests #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run Drone behind Armor with AutoTLS enabled.
However, when enabling the Github integration in Drone it generates
http://
URLs for the OAuth2 redirect URL and also for the Github Webhook URLs since it's configured to serve plain HTTP and is unaware of the proxy.Setting the
X-Forwarded-Proto
header on the request to upstream if the original request was TLS fixes the problem for Drone and probably many others.I tested the happy paths with Drone but:
Upgrade
requests.I don't think any of this leads to problems but I would love your feedback on them.