Skip to content

Conversation

@rolandjitsu
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #11 into master will decrease coverage by 0.19%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #11     +/-   ##
=========================================
- Coverage   56.58%   56.39%   -0.2%     
=========================================
  Files           3        3             
  Lines         129      133      +4     
=========================================
+ Hits           73       75      +2     
- Misses         54       55      +1     
- Partials        2        3      +1
Impacted Files Coverage Δ
casbin/casbin.go 83.33% <66.66%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5babd9...959e9a3. Read the comment docs.

@rolandjitsu
Copy link
Contributor Author

@vishr how do you want to handle the error that a.Enforcer.Enforce(user, path, method) might return? Return an internal server error to the user?

@hsluoyz
Copy link
Contributor

hsluoyz commented Aug 16, 2019

@rolandjitsu I think it's OK. Maybe you want to check how other middlewares handle errors.

@vishr vishr merged commit 4db66e1 into labstack:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants