Timeouts

[aarondl]

https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/

Reading up on this and checking the source code here:
https://github.com/labstack/echo/blob/master/engine/standard/server.go#L51

Looks like there's no default timeouts piled in or maybe even no way to set timeouts in general. It seems like this is important otherwise clients could leak file descriptors and DOS any server running echo.

Thoughts?

[vishr]

ReadTimeout and WriteTimeout are part of engine config https://echo.labstack.com/guide/customization. In addition to that you can extract the original http.Server instance like standard.Server#Server and use it as appropriate.

It is mentioned in the post there is no one-size fit all and using the timeouts will restrict you from uploading large file or sending a streaming response. The best approach could be based on this post by registering a callback for connection state change and take an action. http://stackoverflow.com/a/29334926/197473