Skip to content

Conversation

@jtc42
Copy link
Member

@jtc42 jtc42 commented Apr 23, 2020

No description provided.

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #55 into master will decrease coverage by 0.43%.
The diff coverage is 84.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   98.82%   98.38%   -0.44%     
==========================================
  Files          39       39              
  Lines        1612     1613       +1     
  Branches      247      247              
==========================================
- Hits         1593     1587       -6     
- Misses          6       11       +5     
- Partials       13       15       +2     
Flag Coverage Δ
#unittests 98.38% <84.78%> (-0.44%) ⬇️
Impacted Files Coverage Δ
labthings/core/tasks/__init__.py 100.00% <ø> (ø)
labthings/core/tasks/thread.py 97.67% <66.66%> (-2.33%) ⬇️
labthings/core/tasks/pool.py 90.16% <86.11%> (-8.17%) ⬇️
labthings/server/default_views/tasks.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d279815...9c723c3. Read the comment docs.

@jtc42
Copy link
Member Author

jtc42 commented Apr 23, 2020

@rwb27 Something to be aware of when this gets merged into master. This changes the task and task pool interface to better match Gevent. The taskify function doesn't change at all though, so things like the OFM should be fully compatible.

@jtc42 jtc42 marked this pull request as ready for review April 23, 2020 15:29
@jtc42 jtc42 merged commit 4bcb707 into master Apr 23, 2020
@jtc42 jtc42 deleted the gevent-pool branch April 24, 2020 16:32
rwb27 added a commit to rwb27/python-labthings that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants