Skip to content

Conversation

@jrobison-sb
Copy link

Summary

We would like to be able to upgrade to AWS provider v5.0, which was just recently released.

How did you test this change?

Clone this repo locally, change the version pin, then change my source for the module to point at my local copy. Then I ran a terraform plan and verified that it works, with no diffs.

Issue

#63

@dmurray-lacework
Copy link
Collaborator

make it so

@jrobison-sb
Copy link
Author

@dmurray-lacework thanks for reviewing this. Since CI passed, could we get this merged (and then also get a new release)? Thanks.

@dmurray-lacework
Copy link
Collaborator

Hi @jrobison-sb we have some discussion as to the version pinning and release version here ->
lacework/terraform-aws-cloudtrail#126 (comment)

Note, this PR is not yet approved only the comment trigger to run tests.

@jrobison-sb
Copy link
Author

@dmurray-lacework thanks.

Do you prefer that I change the version pin to ~> 5.0 in this one? And if so, is there anything I would need to do myself to bump the module release version to 3.0.0, or does that happen in the release pipeline?

@dmurray-lacework
Copy link
Collaborator

@jrobison-sb following discussion on the terraform-aws-cloudtrail PR below, we'll be taking a different approach to version pinning. Closing this PR in favour of #65

lacework/terraform-aws-cloudtrail#126 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants