Skip to content

docs: Add contributing documentation #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2021
Merged

docs: Add contributing documentation #13

merged 3 commits into from
Sep 22, 2021

Conversation

@dmurray-lacework
Copy link
Collaborator

@dmurray-lacework dmurray-lacework commented Sep 20, 2021

issue: https://lacework.atlassian.net/browse/ALLY-661

Add contributing documentation

  • CONTRIBUTING.md
  • DEVELOPER_GUIDELINES.md
  • ISSUE_TEMPLATE/bug_report.md
  • ISSUE_TEMPLATE/feature_request.md
  • ISSUE_TEMPLATE/pull_request_template.md

Add make help

❯ make help    
-------------------------------------------------------------------
Lacework terraform-aws-cloudtrail Makefile helper:

 ci - *CI ONLY* Runs tests on CI pipeline
 release - *CI ONLY* Prepares a release of the Terraform module
-------------------------------------------------------------------

Signed-off-by: Darren Murray darren.murray@lacework.net

dmurray-lacework and others added 3 commits September 20, 2021 11:40
@dmurray-lacework
docs: Add contributing documentation
6eb4caf 
Signed-off-by: Darren Murray <darren.murray@lacework.net>
@dmurray-lacework
docs: Address code review comments
3532bca 
Signed-off-by: Darren Murray <darren.murray@lacework.net>
@dmurray-lacework
docs: Fix typo
dd2e1b8
@afiune afiune merged commit 8a20b91 into main Sep 22, 2021
@afiune afiune deleted the dmurray-lacework/ALLY-662/contributing-documentation branch September 22, 2021 22:24
@lacework-releng lacework-releng mentioned this pull request Nov 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@afiune afiune afiune approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmurray-lacework @afiune