feat: add limit_num_imgs variable #25
Conversation
variables.tf
Outdated
| default = 5 | ||
| description = "The maximum number of newest container images to assess per repository. Must be one of 5, 10, or 15. Defaults to 5." | ||
|
|
||
| validation { |
There was a problem hiding this comment.
validation requires Terraform 0.13 or higher. I can remove this if desired.
There was a problem hiding this comment.
Hey @jrobison-sb I think we should add any validation changes to the provider -> https://github.com/lacework/terraform-provider-lacework/blob/main/lacework/resource_lacework_integration_ecr.go#L179
Can you raise an issue against the Lacework Terraform provider instead of adding it in this PR
There was a problem hiding this comment.
@dmurray-lacework Thanks for the feedback. I raised lacework/terraform-provider-lacework#270 and removed the validation from variables.tf.
|
@dmurray-lacework Hi. Any thoughts on this? |
|
Hey @jrobison-sb LGTM just one comment on the validation. |
|
make it so |
|
@dmurray-lacework thanks for merging this. would it be possible to get a new release of the |
|
@jrobison-sb We've just triggered the release -> #26 |
2 participants
Issue: N/A
Description:
limit_num_imgsshould be user configurable. This adds it as a variable so that a user can configure it.Additional Info:
N/A