feat: add support for AWS provider v5 #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also noticed that CI is still being tested using provider version 3. I'm happy to copy/paste a new test case which uses provider v5, or just bump the existing test cases to use v5. |
Collaborator
|
make it so |
Contributor
Author
|
@dmurray-lacework thanks for reviewing this. Since CI passed, could we get this merged (and then also get a new release)? Thanks. |
versions.tf
Outdated
|
|
||
| required_providers { | ||
| aws = ">= 3.0, < 5.0.0" | ||
| aws = ">= 3.0, < 6.0.0" |
Collaborator
There was a problem hiding this comment.
Hi @jrobison-sb from discussion on the other module PR's we'd like to follow the approach here to versioning lacework/terraform-aws-config#65
Contributor
Author
There was a problem hiding this comment.
@dmurray-lacework I pushed a new commit which pins >= 3.0. Thanks.
dmurray-lacework
approved these changes
Jun 2, 2023
dmurray-lacework
approved these changes
Jun 2, 2023
dmurray-lacework
approved these changes
Jun 2, 2023
Collaborator
|
make it so (run tests) |
dmurray-lacework
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We would like to be able to upgrade to AWS provider v5.0, which was just recently released.
How did you test this change?
Clone this repo locally, change the version pin, then change my
sourcefor the module to point at my local copy. Then I ran aterraform planand verified that it works, with no diffs.Issue
#45