fix: enable parallel stackset operations #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipcrm
commented
Nov 16, 2023
versions.tf
Outdated
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = ">= 3.35.0" | ||
| version = ">= 5.11.0" |
There was a problem hiding this comment.
NOTE: the change here, in it's own commit. Please rebase/merge not squash.
ipcrm
changed the title
PengyuanZhao
previously approved these changes
Nov 16, 2023
|
No pitfalls that I'm aware of, but much faster; for both creation as well as update/deletes |
added 2 commits
November 16, 2023 20:08
Python 3.11, the runtime provider for the integration lambda, requires >= v5.11.0. https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.11.0
ipcrm
force-pushed
the
ipcrm/GROW-2583/operating-params
branch
from
9aafe5f to
8e5d13a
Compare
afiune
changed the title
afiune
previously approved these changes
Nov 17, 2023
* chore: downgrade Python version to 3.9 Signed-off-by: Salim Afiune Maya <afiune@lacework.net> * style: create a local variable Signed-off-by: Salim Afiune Maya <afiune@lacework.net> --------- Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Large environments will take hours to deploy if we do not enable parallelization.
How did you test this change?
Manual execution:
Update/deletes tested
Issue
https://lacework.atlassian.net/browse/GROW-2583