chore: Set deletion_protection to false for rollback #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lei Jin <lei.jin@lacework.net>
leijin-lw
requested review from
PengyuanZhao,
aneesh-mysore and
thekeys93
and removed request for
a team
wilderj
approved these changes
Jan 14, 2025
Contributor
wilderj
left a comment
wilderj
left a comment
There was a problem hiding this comment.
Not sure what the CI failures about but the change itself LGTM
Contributor
Author
CI fails because GCP testing project was deleted and cannot be recovered. All GCP terraform CI checks are failing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://lacework.atlassian.net/browse/GROW-3006
How did you test this change?
Test locally with
terraform destoryIssue