Skip to content

Conversation

@wilderj
Copy link
Contributor

@wilderj wilderj commented Sep 3, 2025

Summary

The last changeset removed the requirement for specifying an organization_id in PROJECT level integrations.

Unfortunately, my changes to the Terraform check for this variable had an error. As a result we are firing the "you must include an org ID" for all integrations still.

This PR rectifies that problem.

How did you test this change?

I created a local terraform integration with this change. I verified that:

  1. When integration type is PROJECT and no organization id is specified, we do not get the warning.
  2. When integration type is ORGANIZATION and no organization id is specified, we do get the warning.
    1. When integration type is ORGANIZATION and an organization id is specified, we do not get the warning.

@wilderj wilderj requested a review from kirklandnuts September 3, 2025 18:22
@wilderj wilderj requested a review from a team as a code owner September 3, 2025 18:22
@wilderj wilderj requested review from charanbir, thekeys93 and wsli-1 and removed request for a team September 3, 2025 18:22
@wilderj wilderj changed the title Fix orgid check Fix conditions for specifying the organization_id variable Sep 3, 2025
@wilderj wilderj merged commit 39261d8 into main Sep 3, 2025
11 checks passed
@wilderj wilderj deleted the fix-orgid-check branch September 3, 2025 18:38
@lacework-releng lacework-releng mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants