-
Notifications
You must be signed in to change notification settings - Fork 1
add gordan bio and photo #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis pull request introduces a new Markdown file to add Gordan Prastalo's profile to the team page. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aaneesh1 - I've reviewed your changes - here's some feedback:
- Consider capitalizing the name in the 'title' field.
- Please review the 'bio' field for grammar and typos.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -0,0 +1,17 @@ | |||
| --- | |||
| title: "gordan prastalo" | |||
| role: "phd student" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): Consider capitalizing 'PhD'.
Capitalize 'PhD' since it's an initialism.
| role: "phd student" | |
| role: "PhD student" |
| title: "gordan prastalo" | ||
| role: "phd student" | ||
| image: "team/gordan.jpg" | ||
| bio: "i am a computer scientist by training interested in developing computational tools to accelerate scientific dicovery. my current research interests is to explore how to best represent molecules and generate new ones with desired properties." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Please capitalize 'i'.
Capitalize 'i' as 'I' in the bio.
| bio: "i am a computer scientist by training interested in developing computational tools to accelerate scientific dicovery. my current research interests is to explore how to best represent molecules and generate new ones with desired properties." | |
| bio: "I am a computer scientist by training interested in developing computational tools to accelerate scientific dicovery. my current research interests is to explore how to best represent molecules and generate new ones with desired properties." |
Summary by Sourcery
Add a new team member profile for Gordan Prastalo
New Features:
Documentation: