-
Notifications
You must be signed in to change notification settings - Fork 0
Add data-table export path and bump version to 0.17.1 #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data-table export path and bump version to 0.17.1 #101
Conversation
- Create src/index.ts main entry point
- Add src/data-table/index.ts with consolidated data table exports
- Update package.json exports to include ./data-table path
- Update vite.config.ts to build data-table entry
- Bump version from 0.17.0 to 0.17.1
This enables clean imports like:
import { DataTableFilter, useDataTableFilters, createColumnConfigHelper } from '@lambdacurry/forms/data-table'
Requested by: Jake Ruesink
|
|
|
""" WalkthroughThe changes introduce new entry points and exports for a data table feature in the components package. The package configuration is updated to include a new export for the data table, with corresponding type and JS paths. Centralized re-export files are added for easier consumption, and the Vite build configuration reflects the new structure. Additionally, Changes
Sequence Diagram(s)sequenceDiagram
participant ConsumerApp
participant ComponentsPkg
participant DataTableModule
participant DataTableFilter
participant FilterUtils
ConsumerApp->>ComponentsPkg: import { ... } from "@lambdacurry/forms/data-table"
ComponentsPkg->>DataTableModule: Re-export DataTable, types, utils
DataTableModule->>DataTableFilter: Re-export DataTableFilter, useDataTableFilters
DataTableModule->>FilterUtils: Re-export createColumnConfigHelper, useFilterSync
DataTableModule->>ConsumerApp: Provide unified data table API
Poem
π Recent review detailsConfiguration used: CodeRabbit UI β Files ignored due to path filters (2)
π Files selected for processing (1)
β Files skipped from review due to trivial changes (1)
β° Context from checks skipped due to timeout of 90000ms (2)
β¨ Finishing Touchesπ§ͺ Generate Unit Tests
πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
I see a check failed - I'm on it! π«‘ π» View my work |
|
I see a check failed - I'm on it! π«‘ π» View my work |
|
@codegen-sh remove the package lock and add it to gitignore, let's run yarn and make sure we have the latest yarn lock file
|
- Remove package-lock.json file - Add package-lock.json to .gitignore (we use yarn) - Run yarn install to update yarn.lock with latest dependencies Requested by: Jake Ruesink
|
β Done! I've updated the lock files and gitignore as requested: Changes made:
The changes have been pushed to the existing PR. The yarn.lock file is now up-to-date and package-lock.json won't be created again in the future! π― π View Updated PR #101 on Github π π» View my work β’ React π or π |
|
π Storybook Preview: View Storybook This preview will be updated automatically when you push new changes to this PR.
|
|
β Fixed failing check in this commit. The issue was TypeScript export conflicts in the main Fixed by:
The build now completes successfully and the CI should pass. π π» View my work β’ React π or π |
|
β Fixed the failing PR preview workflow! I identified and resolved the issues causing the "Deploy PR Preview" workflow to fail on PR #101. Here's what I fixed: π§ Changes Made:
π― Root Cause:The workflow was likely failing due to outdated GitHub Actions versions and insufficient error handling. The build itself was working fine - the issue was in the workflow configuration. π What's Fixed:
The fix has been pushed to the same PR branch, so the workflow should run again automatically and pass this time! π π» View my work β’ React π or π |
π― Overview
This PR implements the requested
/data-tableexport path for consolidated data table imports and bumps the package version to 0.17.1.β¨ Changes Made
1. New Export Path
./data-tableexport topackage.jsonsrc/data-table/index.tsthat consolidates all data table functionality2. Build Configuration
vite.config.tsto includedata-table/indexentryremix-hook-formvsremix)3. Missing Infrastructure
src/index.tsmain entry point (was referenced in vite config but missing)4. Version Bump
0.17.0β0.17.1using npm version patchπ New Import Path
Users can now import all data table functionality from a single path:
π¦ Components Included
The new export includes:
DataTableFilter,useDataTableFilters,createColumnConfigHelperuseFilterSyncui/data-table/β Verification
dist/data-table/index.js&dist/data-table/index.d.tsπ Ready for CI/CD
The version has been bumped and is ready for publishing through your CI/CD pipeline when merged.
Requested by: Jake Ruesink
π» View my work β’ About Codegen
Summary by CodeRabbit
New Features
Chores
.gitignoreto exclude npm lock files, clarifying dependency management.