Skip to content

chore: update dependencies and remove obsolete packages #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 20, 2024
Merged

chore: update dependencies and remove obsolete packages #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8454b1f
chore: update dependencies and remove obsolete packages
jaruesink Dec 20, 2024
6c654d2
chore: mark package as private
jaruesink Dec 20, 2024
4177005
chore: add package-lock.json and update dependencies
jaruesink Dec 20, 2024
7c62889
chore: update yarn.lock and enhance dependency management
jaruesink Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/docs/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const config: StorybookConfig = {
addons: [
getAbsolutePath('@storybook/addon-links'),
getAbsolutePath('@storybook/addon-essentials'),
getAbsolutePath('@chromatic-com/storybook'),
getAbsolutePath('@storybook/addon-interactions'),
],
framework: {
Expand Down
4 changes: 1 addition & 3 deletions apps/docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"storybook": "^8.4.7"
},
"devDependencies": {
"@chromatic-com/storybook": "^3.2.2",
"@remix-run/dev": "^2.12.0",
"@remix-run/testing": "^2.12.0",
"@storybook/test-runner": "^0.20.1",
Expand All @@ -31,8 +30,7 @@
"@typescript-eslint/parser": "^6.7.4",
"autoprefixer": "^10.4.19",
"postcss": "^8.4.38",
"react": "^18.2.0",
"storybook-addon-remix-react-router": "^3.0.0",
"react": "^19.0.0",
Copy link

@coderabbitai coderabbitai bot Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

⚠️ Caution: React 19 is not officially released

The update to React ^19.0.0 is premature as React 19 is not yet officially released. This could lead to stability issues.

Recommendation: Keep React at version 18.2.0 until React 19 is officially released and its compatibility with your dependencies (especially Storybook) is confirmed.

-    "react": "^19.0.0",
+    "react": "^18.2.0",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"react": "^19.0.0",
"react": "^18.2.0",

Copy link
Contributor Author

@jaruesink jaruesink Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is now!

Copy link

@coderabbitai coderabbitai bot Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaruesink Thanks for clarifying! If React 19 is officially out and meets your project's needs, there's no issue with keeping it in this PR. Let me know if there's anything else I can help with!

"tailwindcss": "^3.4.10",
"typescript": "^5.1.6",
"vite": "^5.1.0",
Expand Down
Loading
Loading