Skip to content

Conversation

@Bfunk54
Copy link
Contributor

@Bfunk54 Bfunk54 commented Feb 27, 2025

Moved button to a test folder and am no longer exporting it.

Summary by CodeRabbit

  • Refactor
    • Updated import paths for the Button component across multiple story files to ensure consistency.
    • Removed the export statement for the button module from the main index, impacting its availability for import.
    • Adjusted the import source for buttonVariants in the DatePicker component without affecting functionality.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2025

Walkthrough

This pull request standardizes the import sources for the Button component across several story files and adjusts related internal references in the component library. The changes update import paths from the UI variant to a test variant and modify the visibility of an interface. Additionally, a redundant export is removed from the main UI index file, ensuring that the source of the button-related functionality is consistently referenced.

Changes

File(s) Change Summary
apps/docs/src/remix/remix-*.stories.tsx Updated the Button import from @lambdacurry/forms/ui/button to @lambdacurry/forms/test/button in multiple story files.
packages/components/src/test/button.tsx Changed the cn import from ./utils to ../ui/utils and made the ButtonProps interface non-exported.
packages/components/src/ui/(date-picker.tsx, dropdown-menu-select-field.tsx) Updated import paths: date-picker.tsx now imports buttonVariants and dropdown-menu-select-field.tsx imports Button from the new relative path ../test/button.
packages/components/src/ui/index.ts Removed the export statement for the button module (export * from './button';).

Possibly related PRs

Poem

I'm a bunny hopping through lines of code so bright,
Changing paths for buttons with a skip and a light.
Imports now from test, a newfound trail to tread,
With hidden props and revised exports, ahead.
Hop along, dear coder, in this whimsical byte-filled delight!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e170477 and 67db144.

📒 Files selected for processing (1)
  • packages/components/src/ui/date-picker-field.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/components/src/ui/date-picker-field.tsx

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Bfunk54 Bfunk54 requested review from jaruesink and removed request for jaruesink February 27, 2025 20:48
@Bfunk54 Bfunk54 marked this pull request as draft February 27, 2025 20:49
@Bfunk54 Bfunk54 changed the title fix: no longer export the button (Wait until first one is merged for breaking changes) fix: no longer export the button Feb 27, 2025
@dwene
Copy link
Contributor

dwene commented Mar 18, 2025

@Bfunk54 what do we want to do with this PR?

@Bfunk54
Copy link
Contributor Author

Bfunk54 commented Mar 18, 2025

I'll merge it with dev and get it ready for review @dwene . Thank you for the reminder

@jaruesink jaruesink closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants