-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add comprehensive ControlledSelect Storybook stories #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add 10 comprehensive story variants for ControlledSelect component - Cover basic single select, default values, validation, loading states - Include custom option rendering using Select compound components - Add disabled state, error state, and size variants - Include complex form integration and interactive demo - Follow established pattern from ControlledInput.stories.tsx - Use react-hook-form directly without react-router dependencies Note: Multi-select and searchable/creatable variants not included as they are not currently supported by the base Select component
|
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
I see a check failed - I'm on it! 🫡 |
- Fixed duplicate identifier conflicts in ControlledSelect.stories.tsx: - Renamed component function ComplexFormIntegration to ComplexFormIntegrationComponent - Renamed story exports to avoid conflicts: RequiredValidation → SelectRequiredValidation, DisabledState → SelectDisabledState, ErrorState → SelectErrorState - Fixed duplicate identifier conflicts in ControlledCheckbox.stories.tsx: - Renamed component function CompleteFormExample to CompleteFormExampleComponent - Fixed incorrect import path in ControlledCheckbox.stories.tsx: - Changed from '@lambdacurry/medusa-forms/controlled' to '@lambdacurry/medusa-forms/controlled/ControlledCheckbox' These changes resolve the Storybook build failures caused by TypeScript identifier conflicts and import path issues.
|
✅ Fixed failing check suite in this commit. The issue was caused by TypeScript identifier conflicts and import path issues in the Storybook stories: 🔧 Issues Fixed:
🛠️ Solutions Applied:
The PR is ready for review with all build issues resolved! 💻 View my work • React 👍 or 👎 |
|
📝 Storybook Preview: View Storybook This preview will be updated automatically when you push new changes to this PR.
|
a790cdc
into
codegen/lc-240-medusa-forms-controlled-components-documentation-stories-and
Overview
This PR adds comprehensive Storybook stories for the
ControlledSelectcomponent as part of the Medusa Forms controlled components documentation effort.Changes
✨ New Stories Added
🛠️ Technical Implementation
react-hook-formdirectly withFormProvideranduseFormControlledInput.stories.tsxSelect.Trigger,Select.Value,Select.Content, andSelect.Itemfor custom rendering📋 Features Covered
✅ Supported Features:
❌ Not Included (Not Currently Supported):
Note: Multi-select and searchable/creatable variants were not included as they are not currently supported by the base Select component. The types suggest these may be planned features.
🎯 Story Structure
Each story includes:
📁 File Location
apps/docs/src/medusa-forms/ControlledSelect.stories.tsxTesting
The stories demonstrate:
Next Steps
Related: Part of LC-240 Medusa Forms controlled components documentation effort
💻 View my work • About Codegen