Replies: 3 comments 1 reply
-
|
Overall +1, this looks good to me and would make the process much more standard. The 2 concerns I have are
Thoughts? |
Beta Was this translation helpful? Give feedback.
-
|
I like this idea. My only concern is that submodules do not work well these days, especially for agents that depend heavily on worktrees. I'm thinking about adding a CI check for approval on proto changes. This CI check would only pass when three PMC members have approved it. |
Beta Was this translation helpful? Give feedback.
-
|
In the latest sync meeting, we discussed splitting this proposal into 3 parts:
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
TDLR: What if making a format change proposal is just making a PR? And voting +1 is just approving that PR? And enforcing 3 votes is just a branch protection rule requiring 3 approvals?
We require design proposals and PMC votes for changes to the core format (file format, table format, etc.), but in practice this isn't working well:
What I'm proposing:
Curious what people think — especially on write-access scope and whether three approvals is the right bar.
Footnotes
I've tried to add some automated reminders at least in Lance, but nothing has yet landed in LanceDB. ↩
Beta Was this translation helpful? Give feedback.
All reactions